Fix bugs in the climate data lat/lon endpoints - Githubissues

azavea / climate-change-api

Apache License 2.0

0 stars 0 forks source link

Fix bugs in the climate data lat/lon endpoints #871

Closed maurizi closed 5 years ago

maurizi commented 5 years ago

Overview

The climate data endpoints for lat/lon requests were unintentionally broken in PR #866

These endpoints were not previously covered by the unit test suite, and manually testing overlooked these endpoints.

I added some minimal tests in the process of fixing these, which will hopefully prevent other regressions in the future.

Demo

Testing Instructions

./scripts/server
This link should return 404 (instead of 500) http://localhost:8080/api/climate-data/33.404271/-118.415929/RCP85/indicator/heat_wave_duration_index/?dataset=LOCA&variables=tasmax
This link should return 200 and data (instead of 500) http://localhost:8080/api/climate-data/39.9526/-75.1652/RCP85/indicator/average_high_temperature/

Checklist

[x] Does the python linter pass?
[x] Do tests pass?
~[ ] Has the API documentation been updated, or does this PR not require it?~

Closes #869 Closes #870