Explosive Shot Ranks - Githubissues

Manpower99 commented 1 year ago

Current Behaviour

Currently Explosive Shot if applied again by a lower rank of it it will reset the durations but that is not blizzlike. the application of explosive shot (rank 3) will overlap the DoT of explosive shot (rank 4) previously used during LnL proc.

Expected Blizzlike Behaviour

Spells such as Explosive Shot , Explosive Trap, Flamestrike of different ranks should apply different spell IDs that would not reset/overlap them

Source

https://www.wowhead.com/wotlk/spell=56344/lock-and-load#comments to cite : Just tested this with recount. When LnL procs you can cast explosive shot(rank 4) explosive shot(rank 3) explosive shot(rank 4) and it will get all 9 ticks and it does more damage than an explosive shot(rank 4) spam. Very handy when you need that big burst of damage and every second counts.

Steps to reproduce the problem

Trigger Lock and Load 1.Use Explosive shot rank 4 2.Use explosive shot rank 3 before the dot is over

Extra Notes

Worth to note that the DoT from each explosive shot rank do not share a spell ID (they are different spell ID's) same goes for alot of spells such as flame strike and explosive trap

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/5c31998573613c7564d4d5a9b050d2656b0e4c23

Operating system

win10

Custom changes or Modules

No response

v-mstrs commented 1 year ago

8a01b19/src/server/game/Spells/Auras/SpellAuras.cpp#LL2035C1-L2035C115

BugSquisher9000 commented 1 year ago

thats a nice code line there, feels like this guy did not like that mages could stack flamestrike and decided to just add it in.

Tereneckla commented 1 year ago

Except that flamestrike is a ground dot that is handled differently Debuffs/Auras in fact generally do not stack