(Spells): Ritual of Summoning.

[heyitsbench]

Current Behaviour

1. The portal created by the warlock is at the same position as the warlock.
2. Players who click the warlock's portal do not play a casting animation.
3. The ritual is completed immediately when the third person clicks the portal.
4. There is a cast time to create portals.
5. The teleported player has no change to their orientation.
6. Only one other person can click the portal.

Expected Blizzlike Behaviour

1. It should be a few yards in front of the warlock when they cast the spell.
2. They should play the same animation as the warlock when they've clicked the portal.
3. There should be a small delay between when the third person clicks (they still play an animation) and when the closet is created. 3a. The ritual can be interrupted if the third player (likely the second as well, didn't check) clicks the portal (plays the animation) and steps away before it is completed. This does not consume a soul shard from the warlock.
4. Creating portals to summon players should be instant.
5. The teleported player should have their orientation changed to match the warlock when they clicked the closet/created the portal.
6. While not consistent (and likely not intended,) it is sometimes possible for a third person to click the portal and play the casting animation.

Source

Wrath Classic primarily, light double checking from retail videos of the time

Steps to reproduce the problem

1. .learn 698
2. Play around with the ritual.
3. Observe the results.

Extra Notes

Split from https://github.com/azerothcore/azerothcore-wotlk/issues/17010.

AC rev. hash/commit

4f015d09678038be49e9d12114c3147e499d82ef

Operating system

Windows 10 x64

Custom changes or Modules

mod-ptr-template

[Saqra1]

The teleported player should have their orientation changed to match the warlock when they clicked the closet/created the portal.

There was a similar issue regarding orientation, #18936, it was mentioned that this behavior is from classic not from original WotLK. So it probably is not right for summoning either.

[heyitsbench]

So it probably is not right for summoning either.

I cannot find it now, but I do recall hunting down a video at the time of making this issue that did demonstrate the orientation of the summoned matching the summoner on original retail. I am very much of the opinion that home binding and summon positioning are quite unrelated in the backend, but seeing as I can't find video evidence of it at this exact moment, I'm not gonna try to die on this hill. 😛

[heyitsbench]

The portal created by the warlock is at the same position as the warlock.

The spell (698) has EffectImplicitTargetA set for the summon effect to 47, TARGET_DEST_CASTER_FRONT, this just doesn't seem to be reflected in-game, likely affects other spells such as mage's Ritual of Refreshment.

[Saqra1]

According to a sniff, it appears that the characters assisting with the ritual (i.e. clicking the portal) are channeling the 698 spell alongside the warlock

_Originally posted by @heyitsbench in https://github.com/azerothcore/azerothcore-wotlk/pull/19554#discussion_r1703437581_

It looks like this is the case for all ritual player spells:

• Ritual of Summoning - 698
• Ritual of Souls (Rank 1) - 29893
• Ritual of Souls (Rank 2) - 58887
• Ritual of Doom - 18540
• Ritual of Refreshment (Rank 1) - 43987
• Ritual of Refreshment (Rank 2) - 58659

Each ritual has a different animation for players clicking but it's the same as the warlock or mage starting the ritual.

Searching how other projects handle it I found this: https://github.com/cmangos/mangos-wotlk/commit/6eaef417163174ffa2f6e4943ded4b11784fa62d. If a summoning ritual Game Object doesn't have animSpell set, they use the same spell but flag it as to not execute its effects, just to play the animation.

[heyitsbench]

Recap of this issue:

• [X] The initial portal is created on top of the warlock. (67010623a0670b507cbfd2ffc7e9cea7bcfca1a2, though still seems to be too close to the warlock.)
• [X] Players who click the warlock's initial portal do not play a casting animation. (ed824de7b803a4f66c2cc35918bb23077db62124)
• [X] The ritual is completed immediately when the third person clicks the initial portal. (ed824de7b803a4f66c2cc35918bb23077db62124)
• [X] There is a cast time to create summoning portals. (67010623a0670b507cbfd2ffc7e9cea7bcfca1a2)
• [ ] The teleported player has no change to their orientation.
• [ ] The initial ritual cannot be interrupted if a player begins channeling and steps away. (Might be resolved, will need to double check.)
• [ ] Only one other person can channel the summoning portal.

[Saqra1]

The ritual is completed immediately when the third person clicks the initial portal. (Might be resolved, will need to double check.)

This was resolved too. Although it uses the same delay for all rituals, 5s from the last player click. I am not sure if they are different.

[Saqra1]

though still seems to be too close to the warlock.

Portal distance from an old video https://youtu.be/b_i7ujhBYM8?t=146 (@~2:26):

Current portal distance:

Local test setting a 3yd distance:

Looks about right?

[Helias]

@heyitsbench ?