search

azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.5k stars 2.61k forks source link

(DB/Spell): Replace `spell_dbc` corrections with entries in SpellInfoCorrections. #17384

Open heyitsbench opened 1 year ago

heyitsbench commented 1 year ago

Current Behaviour

There are various spells in spell_dbc that already exist in the client DBC file. These entries exist as a past way of handling corrections to spell info. Currently any corrections to existing spells are being handled through SpellInfoCorrections.cpp. These are the spells that are mirrored between the spell_dbc table and the Spell DBC file.

Expected Blizzlike Behaviour

There should be no overlapping entries in spell_dbc and Spell.DBC. Any overlapped entries are corrections that should be converted to entries in SpellInfoCorrections.

Extra Notes

At some point I probably will go through these entries and add the offending fields to the table, but I'm lazy right now.

AC rev. hash/commit

c25d0b38e8c035faf1a550b42c7b67a032e4ab14

Kitzunu commented 10 months ago

Have fun trying to figure out what changed kek https://github.com/azerothcore/azerothcore-wotlk/commit/d7981de01e739addf30035a2701538606baea2e6 (This is why spell_dbc is bad for corrections)