azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.63k stars 2.64k forks source link

Visible Invisible trigger #18330

Open chaosua opened 9 months ago

chaosua commented 9 months ago

Current Behaviour

Steam Springs triger with golem model NPC ID: 25739 - Steam Vent is visible for players, it wandering near Steam Ragers npc25739 model 169 is golem, model 23343 is steaming look

Karazhan And (Shade of Aran Teleport _ ) ID 17175, 17171, 17168, 17172, 17170, at Karazhan Guardian's Library npc_Shade of Aran Teleport there are also triggers that are not visible in normal and gm mode (ID 17173), comparing their parameters shows that the parameter of the modelid2 is 0 and modelid1=15435 (transperant model). And Visible trigers have modelid2=1126. If we enable gm mode visible triggers in normal mode become with invisible model in gm mode. I tried swap modelids on Shade of Aran Teleport W UPDATE creature_template SET modelid1 = 1126, modelid2 = 15435 WHERE entry = 17171; than all become visualy normal -> transperant in normal mode and golem in gm mode model_swap

asuming that triggers have 2 models https://www.wowhead.com/wotlk/npc=17170/shade-of-aran-teleport-e so my suggestion is for Karazhan to swap ID UPDATE creature_template SET modelid1 = 1126, modelid2 = 15435 WHERE entry IN (17168, 17169, 17170, 17171, 17172, 17173, 17174, 17175, 17176); for Steam Vent swaping models doesn't help :( but setting flags_extra=128 may be helpful UPDATE creature_template SET flags_extra = flags_extra | 128 WHERE entry = 25739; and i think steam vent must not have random movement. It has MOVEMENT_TYPE=0 UPDATE creature SET wander_distance = 0 WHERE id1 = 25739; STEAMVENT

Expected Blizzlike Behaviour

triggers should be invisible for normal players

Source

No response

Steps to reproduce the problem

Steam Springs .gm off .go creature 108535

karazhan .gm on .go creature 135172 (center of library) .gm off

Extra Notes

i think that modelid1 and modelid2 must be swapped. So the invisible model 15435 will be in normal mode and 1126 in gm mode

AC rev. hash/commit

b6ee4f49cfbfc907b91fab446de7d207a2bff8bc

Operating system

All OS

Custom changes or Modules

No response

heyitsbench commented 9 months ago

The real fix for these trigger creatures is display probabilities.

kissingers commented 9 months ago

https://github.com/azerothcore/azerothcore-wotlk/issues/18107 the same as this

chaosua commented 9 months ago

so the main bug is there https://github.com/azerothcore/azerothcore-wotlk/issues/15932 which lead to https://github.com/azerothcore/azerothcore-wotlk/issues/5463 and possible hadache fix https://github.com/TrinityCore/TrinityCore/commit/9d210476e57949094fdd286001ef4900564edca5 to be equal to description in https://www.azerothcore.org/wiki/creature_template#modelidx