azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.41k stars 2.57k forks source link

[BlackTemple] Illidan problems #18667

Open kissingers opened 5 months ago

kissingers commented 5 months ago

Current Behaviour

At EVENT_PHASE_2_START, the boss only fly one time and drop to ground, then run in ground but not fly'. the problem like this bug report: https://github.com/azerothcore/azerothcore-wotlk/issues/18551 It sees some spell action destroy the disableGravity, any spell will let the creature drop to ground, so must before use GetMotionMaster do these again, me->SetDisableGravity(true); me->SendMovementFlagUpdate(); just like https://github.com/azerothcore/azerothcore-wotlk/commit/46ba1ba6a327db712a219cef8f09d2c24ae7bc5a at line 345-346 I think might find and fix the problem destroy the DisableGravity at any spell in script AI. So all these problem will automatic fixed

At EVENT_PHASE_5_START, when me->CastSpell(me, SPELL_SHADOW_PRISON, true) sometimes the boss will outcombit might need set me->SetReactState(REACT_PASSIVE) before or after SPELL_SHADOW_PRISON immediately. or change SPELL_SHADOW_PRISON spell will not let boss outcombit

At EVENT_PHASE_5_SCENE5 , if boss's Victim died with SPELL_SHADOW_PRISON and in fire. The Server Crash, might need like this: https://github.com/azerothcore/azerothcore-wotlk/pull/18653/commits/15ef5fc57f8405d91fb9377e7889463d987953c5 or like this if (me->GetVictim()) me->SetTarget(me->GetVictim()->GetGUID()); else DoMeleeAttackIfReady();

And if outcombit after EVENT_PHASE_5_START, and restart fight with the boss, the boss will not selectable, might add these at BossAI::Reset() me->SetReactState(REACT_AGGRESSIVE); me->RemoveUnitFlag(UNIT_FLAG_NOT_SELECTABLE | UNIT_FLAG_NON_ATTACKABLE);

Expected Blizzlike Behaviour

N/A

Source

No response

Steps to reproduce the problem

N/A

Extra Notes

No response

AC rev. hash/commit

AzerothCore rev. e863873d4c80 2024-04-03 19:36:53 +0000 (master branch) (Unix, RelWithDebInfo, Static) Connected players: 0. Characters in world: 0. Connection peak: 0. 服务器运行时间: 29 second(s) Update time diff: 10ms. Last 500 diffs summary:

Operating system

debian12 x64

Custom changes or Modules

No response

icedcolor commented 3 months ago

@kissingers The TrinityCore of the Illidan fight is perfect