azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.47k stars 2.59k forks source link

(Scripts): Training Dummies evade out of combat after five seconds of no damage. #19492

Open heyitsbench opened 2 months ago

heyitsbench commented 2 months ago

Current Behaviour

Currently Training Dummies will evade if they've had no damage for five seconds.

Expected Blizzlike Behaviour

Their timer should also be reset by any hostile action, e.g. spamming Drain Soul (with .cheat cooldown on) should not cause them to leave combat.

Source

Assumption

Steps to reproduce the problem

  1. .cheat cooldown on
  2. .learn 1120
  3. .go c id 31146
  4. Spam Drain Soul on the dummy.
  5. Observe it will leave combat.

Extra Notes

No response

AC rev. hash/commit

0764c654e1cd70ea169e0fac2cbd9c707a0b6fd8

Operating system

Windows 10 x64

Custom changes or Modules

mod-ptr-template

alecsci commented 1 month ago

Confirmed ✅ on de1e42bd83fe149b9d24239df05e4d5ae7f72d38 Windows 11 x64, no modules.

If the dummy doesn't take damage for 5 sec, it will reset. Iif you want to test your damage against a dummy where you have poor hit ratio, the dummy will reset a lot.