azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.44k stars 2.59k forks source link

Elemental Wand Damage Affected By Physical Damage Debuff #9130

Closed Azcobu closed 2 years ago

Azcobu commented 2 years ago

What client do you play on?

enUS

Faction

Content Phase:

Current Behaviour

Original report: https://github.com/chromiecraft/chromiecraft/issues/2298

I have a wand [Gravestone Scepter] equipped. The wand deals shadow damage. While questing in Duskwallow Marsh I fighted the spiders at the cave north of Brackenwall village. During fighting with my wand the wand dealt about 30 to 50 damage in average. Then I got infected by the poison "Debilitating Poison" which reduces my physical damage dealt by 75%. This also affected my wands damage. See combat logs.

WoWScrnShot_111021_142129 I get infected by the poison and my wand deals between 11 and 14 damage non-crit.

WoWScrnShot_111021_142133 After the poison fades my wands damage goes up to between 36 and 56 damage. The log also says that the wand deals shadow damage.

I was not able to test this with other magical wands. This needs some further investigation to maybe identify a general problem with magical wands dealing physical damage.

Tester: confirmed. Tested with the Sceptre and aura 43133 and the damaged increased markedly when the debuff wore off:

WoWScrnShot_111121_220150

@gurveleg comments:

Wands are not considered spells so they arent affected by any spell modifiers. Wands however do elemental damage (or physical damage in the case of pearl wand) and that should not be affected by a physical damage reduction (except pearl wand), even tho the shoot ability itself is considered phyical ability. Its about damage. Mobs that are immune to shadow or fire damage wont take any damage from fire or shadow damage wands for example.

So the physical damage rduction poison reducing a shadow damage wand damage is defiantely a bug.

@Nyeriah comments:

Both statements are correct. Yes, this bug happens because the Shoot ability is physical and we just edit the school of the damage dealt during execution according to the wand type, without checking for the rest.

Also see discussion on TC here: https://github.com/TrinityCore/TrinityCore/issues/16058

Expected Blizzlike Behaviour

Wand with magical damage (shadow, frost, fire, holy, ...) should not be affected by physical damage lowering debuffs since it is magical damage.

Physical damage lowering debuffs should only affect physical damage wands like [Pearled Wand].

Source

https://wowpedia.fandom.com/wiki/Wand?oldid=2356128

Steps to reproduce the problem

  1. .additem [Gravestone Scepter]
  2. cast .aura 43133 on yourself.
  3. Wand damage gets reduced

Extra Notes

Gravestone Scepter: https://wowgaming.altervista.org/aowow/?item=7001 Debilitating Poison: https://wowgaming.altervista.org/aowow/?spell=43133

Pearled Wand (physical wand example): https://wowgaming.altervista.org/aowow/?item=36655

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/12e92b58082dfda8b73b50aa97b98b9479bb7629

Operating system

Windows 10

Modules

Customizations

None

Server

ChromieCraft

Nyeriah commented 2 years ago

Just to add to this: I believe the issue is that the damage calculations already happened by the time we change the schooltype, it might seem like an obvious conclusion, but perhaps it helps looking into it later