fix. crash when using command from terminal - Githubissues

azerothcore / mod-better-item-reloading

BetterItemReloading is a C++ Azerothcore module which allows to reload items on the server side and as much as possible on the client side of WoW 3.3.5.

http://azerothcore.org/

MIT License

12 stars 26 forks source link

fix. crash when using command from terminal #11

Closed pangolp closed 8 months ago

pangolp commented 8 months ago

Changes Proposed:

The command currently attempts to obtain a pointer to a player that does not exist, and that causes the emulator to crash and stop working.
What I have not tested because it is not the issue of this pull request, is whether it actually refreshes the item for all connected players. Because from what I see in the code, it does not go through a list of players at any point, in the last part of the code, to be able to send the packet.

Issues Addressed:

Closes https://github.com/azerothcore/mod-better-item-reloading/issues/10

SOURCE:

Tests Performed:

Windows 10
In-game

How to Test the Changes:

Run the command in terminal
Run the command within the game
In both cases the command should work.

WoWScrnShot_031324_005852

WoWScrnShot_031324_005855

WoWScrnShot_031324_005903

console1

console2