azerothcore / mod-progression-system

ChromieCraft Progression System
GNU Affero General Public License v3.0
59 stars 56 forks source link

Some arena rewards have the wrong cost value #350

Open ghost opened 1 year ago

ghost commented 1 year ago

Originally reported on CC: https://github.com/chromiecraft/chromiecraft/issues/6089 Reported by: sassouiabd

What client do you play on?

enUS

Faction

Both

Content Phase:

70

Current Behaviour

based on all gathered evidence, these are the original S1 pre-cost-nerf TBC prices vs the current CC prices:

Armor set 5/5 - 8250 (blizz) vs 8250 (cc) Melee 2h - 3750 (blizz) vs 3750 (cc) Caster 2h - 3750 (blizz) vs 3750 (cc) Hunter bow - 3750 (blizz) vs 3750 (cc) Caster MH - 3150 (blizz) vs 3150 (cc) Melee MH/1H - 2625 (blizz) vs 1875 (cc) -- too low Melee OH - 1125 (blizz) vs 1875 (cc) -- too high Shields - 1875 (blizz) vs 1875 (cc) Caster OH - 1125 (blizz) vs 1875 (cc) -- too high Wand/Thrown/Relic - 1000 (blizz) vs 1875 (cc) -- too high

I highlighted the ones which need correction. If CC wishes to keep the prenerf s1 pricing system, these would be the correct values.

Expected Blizzlike Behaviour

All item prices should match the prenerf blizzard values.

Source

https://wowwiki-archive.fandom.com/wiki/Season_2_Arena_rewards https://us.forums.blizzard.com/en/wow/t/season-1-vs-season-2-cost/1163028 https://us.forums.blizzard.com/en/wow/t/pvp-gear-cost-tbc-season-1/977656/2

In detail:

Steps to reproduce the problem

Go to arena point vendor and check the prices https://www.wowhead.com/wotlk/npc=24392/leeni-smiley-smalls .go c 3000034

Extra Notes

Affected items:

One hand: https://www.wowhead.com/wotlk/item=28305/gladiators-pummeler https://www.wowhead.com/wotlk/item=28308/gladiators-cleaver https://www.wowhead.com/wotlk/item=28312/gladiators-shanker Main hand: https://www.wowhead.com/wotlk/item=28313/gladiators-right-ripper Offhand: https://www.wowhead.com/wotlk/item=28302/gladiators-bonecracker https://www.wowhead.com/wotlk/item=28307/gladiators-quickblade https://www.wowhead.com/wotlk/item=28309/gladiators-hacker https://www.wowhead.com/wotlk/item=28310/gladiators-shiv https://www.wowhead.com/wotlk/item=28314/gladiators-left-ripper Thrown: https://www.wowhead.com/wotlk/item=28319/gladiators-war-edge Wand: https://www.wowhead.com/wotlk/item=28320/gladiators-touch-of-defeat Offhand: https://www.wowhead.com/wotlk/item=28346/gladiators-endgame https://www.wowhead.com/wotlk/item=32452/gladiators-reprieve Relic: https://www.wowhead.com/wotlk/item=28356/gladiators-libram-of-justice https://www.wowhead.com/wotlk/item=33948/gladiators-libram-of-vengeance https://www.wowhead.com/wotlk/item=28355/gladiators-idol-of-tenacity https://www.wowhead.com/wotlk/item=28357/gladiators-totem-of-the-third-wind https://www.wowhead.com/wotlk/item=33942/gladiators-idol-of-steadfastness https://www.wowhead.com/wotlk/item=33945/gladiators-idol-of-resolve https://www.wowhead.com/wotlk/item=33939/gladiators-totem-of-indomitability https://www.wowhead.com/wotlk/item=33951/gladiators-totem-of-survival

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/280822cb8350213f374e59741506a607ce17dcaa

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft

heyitsbench commented 1 year ago

Here's a rather important question: did Blizzard modify the existing ItemExtendedCost.dbc entries or add new ones for the nerf?

ghost commented 1 year ago

I've no clue, how would you find out something like that? All I can tell is that they clearly had trouble with the odd numbers when halving. They just rounded them down to the nearest hundred.