Open owenfarrell opened 1 year ago
SonarCloud Quality Gate failed.
0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells
No Coverage information
26.7% Duplication
any update on this enhancement? this would save a lot of headaches for folks who didnt notice this behavior and encountered significant cascading impacts (resource re-creation)
Failed conditions
20.6% Duplication on New Code (required ≤ 3%)
Signed-off-by: Owen Farrell owen.farrell@gmail.com
Fixes #140 Supercedes: #196
PR Checklist
resourceDefinition.json
models_generated.go
file in my PR)Description
Does this introduce a breaking change
While this doesn't inherently introduce a backwards-breaking change, I'm not sure that my attempt at an auto-upgrade is a sure thing. The approach that I used was a bit of a "guess and check" based on the existing outputs. In a worst case scenarios, anyone who attempts to auto-upgrade will incur the existing behavior (a forced deletion/recreation of downstream resources) one last time. Any suggestions on how to mitigate this issue would be appreciated.
Testing
In addition to local unit testing, I've exercised these updates via a local provider override and it seems to meet the need.