search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Australian Public Holidays #112

Closed Milamber33 closed 6 years ago

Milamber33 commented 6 years ago

Proper handling for (just about) all public holidays in every Australian state and territory.

stelgenhof commented 6 years ago

Thanks! Sorry for not replying sooner. There is no need to close PR's if something needed to change. I'll review your PR and merge it if it looks good :)

Milamber33 commented 6 years ago

Okay, got those ones you pointed out, and all the other instances where they were copied. There could well be more missing type declarations, I was working based off the current release when adding the extra files, and I used copy+paste a lot. Just let me know if you see any and I'll deal with them. :)

stelgenhof commented 6 years ago

Thanks a lot!

My apologies if I haven't been clear. Indeed the current stable release supports PHP 5.6 and greater. The development branch only supports PHP7 and greater and will be the basis for the next v2.0 release. I haven't documented/communicated that properly (yet).

Milamber33 commented 6 years ago

No problems. :)