search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

tests: use HHVM 3 #114

Closed DanielRuf closed 6 years ago

DanielRuf commented 6 years ago

HHVM 3.30 will be the last release with PHP support. Currently not many dependencies support the HHVM engine.

stelgenhof commented 6 years ago

Thank you for your PR! I wasn't aware that HHVM 3.30 will be the last release with PHP support. Just a quick question: any particular reason you added the Xenial distribution to the configuration?

Cheers! Sacha

DanielRuf commented 6 years ago

Just a quick question: any particular reason you added the Xenial distribution to the configuration?

Yes, because it failed on Trusty, but I can try again without setting it to Xenial.

stelgenhof commented 6 years ago

@DanielRuf The tests seem to be successful. Are you planning on doing some more tests or is the PR ready in your opinion?

DanielRuf commented 6 years ago

This PR is ready to be merged.