search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

International Womens Day #133

Closed huehnerhose closed 5 years ago

huehnerhose commented 5 years ago

International Womens Day is a one time holiday in Germany/Berlin in 2019.

Since it is a common holiday in Russia, I moved it to common holidays and added german localisation and the Germany/Berlin exception for 2019.

I moved it to common holidays, because I think women are at least as important as animals. (World Animal Day seems only be used in the Netherlands but is in commonHolidays, I think International Womens Day deserves its place there, too)

stelgenhof commented 5 years ago

Thanks for the PR! Any holiday can be added, as long as they are official/national or a defacto holiday in the respective provider (country) :) Just make sure you assign the correct type.

Cheers! Sacha

huehnerhose commented 5 years ago

I updated Ukraine, since it also used a custom holiday add.

Regarding the general unit test: I don't see where I should add this? There are tests for Russia, Ukraine and Germany/Berlin, which work now. Please give me a hint where I should add the general test.

Thanks!

Edit: I realised: International Women's Day becomes a holiday 2019 in Berlin. It isn't a one time thing.

stelgenhof commented 5 years ago

@huehnerhose Thanks! Ignore my comment regarding the general unit test: I thought I always did that for common holidays, but that is not the case. Your unit tests are fine :)

Only one last request: Can you add an entry to the CHANGELOG.md file describing this change? That would be great. Once done, I'll have a final check and will merge it.

Cheers! Sacha

huehnerhose commented 5 years ago

Sure :) and done.