search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Added Nigeria Holiday #317

Closed mitmelon closed 10 months ago

mitmelon commented 1 year ago

Added Nigeria Holiday

stelgenhof commented 1 year ago

@mitmelon Thank you very much for your PR, however you have not added any unit-tests. Without unit-tests makes it hard to verify your code is working (and as designed). Please follow the guidelines outlined here: https://github.com/azuyalabs/yasumi/blob/develop/CONTRIBUTING.md

Also you have two PRs (#316 and #317) that contain the same file: this will cause conflicts when merging. It is better to keep everything in a single PR.

mitmelon commented 1 year ago

@mitmelon Thank you very much for your PR, however you have not added any unit-tests. Without unit-tests makes it hard to verify your code is working (and as designed). Please follow the guidelines outlined here: https://github.com/azuyalabs/yasumi/blob/develop/CONTRIBUTING.md

Also you have two PRs (#316 and #317) that contain the same file: this will cause conflicts when merging. It is better to keep everything in a single PR.

Okay... Thanks... Will correct all this tomorrow and add testcase...as stated.

stelgenhof commented 1 year ago

@mitmelon Just wanted to follow up after my last reply. Do you still need any help with your PR?

github-actions[bot] commented 11 months ago

Since this pull request has not had any activity within the last 90 days, I have marked it as stale. I will close it if no further activity occurs within the next 10 days.