search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Adding missing countries. #318

Closed miguelanruiz closed 5 months ago

miguelanruiz commented 1 year ago

Hey there,

Now is missing Colombia, Peru and Mexico, so i think you could include with this pullr, main idea is another applications can has updated dates.

Best regards,

stelgenhof commented 1 year ago

@miguelanruiz Thank you so much! This is great. I will review your PR.

stelgenhof commented 1 year ago

@miguelanruiz Your PR has a few issues: please check the coding style and the static analysis results. You should be able to run these checks locally and make fixes accordingly.

miguelanruiz commented 1 year ago

Hey there,

Its okay, i will check sr

miguelanruiz commented 1 year ago

I think is ready now

stelgenhof commented 1 year ago

Thanks! The tests will likely fail as there are some other issues. These are not related to your PR so you can ignore those. Only check any errors that are coming from your code :)

stelgenhof commented 1 year ago

@miguelanruiz The code styling and static analysis jobs are all fine now, however many of your unit tests are failing. You may want to check if your tests cover the calculation rules of those holidays correctly. (Again, please ignore any test errors from other countries).

miguelanruiz commented 1 year ago

Hi @stelgenhof

Im confused with this:

image

It comes from an interface? could you help me with an example

stelgenhof commented 1 year ago

@miguelanruiz Sure! Argument 4 of that method assertHoliday expects an object and not a string. Please check the signature of that method. The expected object should either be DateTime or DateTimeImmutable (which implements the DateTimeInterface.

stelgenhof commented 1 year ago

@miguelanruiz Just wanted to follow up after my last reply. Do you still need any help with your PR?

stelgenhof commented 11 months ago

@miguelanruiz Any updates? You may want to rebase your PR/branch as I fixed a few bugs.

github-actions[bot] commented 6 months ago

Since this pull request has not had any activity within the last 90 days, I have marked it as stale. I will close it if no further activity occurs within the next 10 days.