search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Fix, Provider\Germany: Pentecost is not an official holiday - except in Brandenburg #337

Closed fbett closed 2 months ago

fbett commented 5 months ago

Hi,

Pentecost was originally removed from the list of general holidays in https://github.com/azuyalabs/yasumi/pull/100. That's because pentecost is not an official holiday (until today) - except in Brandenburg.

I don't know why, it was added again in https://github.com/azuyalabs/yasumi/pull/225.

So i don't remove pentecost from the list of general holidays again, but it is generally marked as TYPE_OTHER.

Previous #334

stelgenhof commented 5 months ago

@fbett Your code is failing because of new PHP CS rules. Please run the following on your PR/branch: composer cs-fix. And also run the tests locally first before committing: composer test.

When all is without errors, please commit. Then it should be good! :)

fbett commented 5 months ago

The PR is refreshed.