search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Update secondChristmasDay.php #53

Closed AngelinCalu closed 7 years ago

AngelinCalu commented 7 years ago

Boxing Day concept does not exist in the US. This should be instead "Second Christmas Day".

stelgenhof commented 7 years ago

After having a closer look, the USA doesn't observe a second Christmas Day. The translation in this file for the 'en_US' does not relate to a (possible) second Christmas Day: it is merely the 'translation' of it for other countries where a second Christmas Day is observed. Nonetheless, if it makes sense for the en_US locale to have it changed, then we can adjust this :)

AngelinCalu commented 7 years ago

Yes. In my case I am only using the english version of the holidays for several countries from Europe. Probably most of the users are interested in the english version as well. As I see it, all holidays should have a common (english) translation.