search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Provider for Israel #58

Closed AronNovak closed 4 years ago

AronNovak commented 7 years ago

Potentially based on https://github.com/mooffie/holidays See also: https://en.wikipedia.org/wiki/Public_holidays_in_Israel

AronNovak commented 7 years ago

As implementing the logic for this provider would totally differ from all we have, due to a totally separate date system in use, would it be acceptable to ember https://github.com/mooffie/holidays via composer, where this problem is already solved?

stelgenhof commented 7 years ago

Thanks for creating this issue. I am not familiar with the Jewish Calendar system, however Yasumi's base calendar system is Gregorian. From what I can see, it should be possible to map the Jewish holidays to the Gregorian system.

No sure what you mean by 'embed', but that library seems quite old. I prefer not to have any dependencies in this library as the goal is that Yasumi provides all the calculations/algorithms itself.

github-actions[bot] commented 4 years ago

This issue has been open 60 days with no activity. Please remove the stale label or comment, or this will be closed in 10 days.