search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Repentance Day should be official in Germany/Saxony #63

Closed scrobbleme closed 6 years ago

scrobbleme commented 7 years ago

Repentance Day is an official holidy in Germany/Saxony, but listet as "Others" within Yasumi

http://www.officeholidays.com/countries/germany/regional.php?list_year=2017&region_code=SN

stelgenhof commented 7 years ago

Yes, the type "Others" is indeed not quite right for official regional holidays. The reason for choosing "Other" was probably because the other types didn't fit the classification.

Actually, the main classification "National" (within Yasumi) is then not appropriate in this regards. I think changing that name to "Official" might be a better wording. However that would require a change to all holiday providers. Which I think may be the correct way :)

For the moment, you can adjust it yourself by changing the type to "NATIONAL" if you like. Let me see if I can resolve this by changing "NATIONAL" to "OFFICIAL" or something like that.

stelgenhof commented 7 years ago

Created branch 'official' where the name change from NATIONAL to OFFICIAL is done.

stelgenhof commented 6 years ago

Issue has been resolved in the master branch. Will be included in the upcoming v1.7.0 release.