Fix Saxony (Germany) test for other holidays

azuyalabs / yasumi

The easy PHP Library for calculating holidays

https://www.yasumi.dev

Other

1.04k stars 152 forks source link

Fix Saxony (Germany) test for other holidays #68

Closed lukosius closed 6 years ago

lukosius commented 6 years ago

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes

Generated random year (initial 1990) can sometimes be lower than established holiday (Repentance and Prayer Day) date 1995 which causes test to fail.

stelgenhof commented 6 years ago

Thank you! I actually already discovered this but haven't had the chance to correct it. Some unit tests still might need to get adjusted in these kind of situations. Not all of them have been reviewed yet.

Thanks for the PR!

stelgenhof commented 6 years ago

Just have resolved this in other commit. The code for Saxony had to be adjusted as Repentance is an official holiday. So included also your code change :). Thanks for the contribution!