search

azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

Holiday Provider for Bosnia #94

Closed TheAdnan closed 6 years ago

stelgenhof commented 6 years ago

Thanks for the PR! According to my research, these are not all the official Bosnian holidays, are they? For example, I saw there is a second New Years Day and a second Labour Day. Do you maybe have a good resource that explains the official/national holidays?

Cheers! Sacha

TheAdnan commented 6 years ago

Hey Sacha, thanks for the info, I thought it was by default that the second New Years Day and Labour day were holidays, my bad. I've fixed it, and I've also added the Orthodox Christmas Day. Let me know if there's any other issue.

Cheers, Adnan :tulip:

stelgenhof commented 6 years ago

I think it looks good now. However, due to the various religions and various jurisdictions in Bosnia, maybe other holidays need to be added.

Source: https://en.wikipedia.org/wiki/Public_holidays_in_Bosnia_and_Herzegovina

TheAdnan commented 6 years ago

There are at least two holidays from the islamic calendar (hence the issue/suggestion earlier), and I think some Orthodox Christian holidays (gotta research this a bit more), so I'll update this again soon :)

stelgenhof commented 6 years ago

No problem. I merged already the code into the 'develop' branch. If you have any PR's, please submit for the 'develop' branch. The master branch is considered production level code :)

TheAdnan commented 6 years ago

Oh sorry, I'll keep that in mind next time :smiley: