Spelling fixes for da_DK

[c960657]

Fix a few language issues for da_DK:

• Holiday names are not proper nouns and they should thus not be written in Title Case (except Kristi himmelfartsdag because Kristi (Christ) is a proper noun). This is according to the official Danish ortography (source: § 12.13.c in Retskrivningsordbogen – the authoritative reference for the Danish language), though Title Case may occasionally be seen in the wild. When used in a sentence, holidays should not be written in lowercase like any other word. AFAICT Yasumi provides stand-alone names, and for this purpose uppercasing the first letter of the first word is appropriate.
• For consistency with Påskedag (Easter Day) and Pinsedag (Pentecost), I have changed 1. juledag to Juledag. All three days may be referred to as 1. xxxdag (literally _First Xxx Day) similar to 2. xxxdag, but I believe they are most commonly referred to with the 1..

The provider currently supports what are usually known as holidays (hellidage) in Denmark. Other days are also important: 1) Lukkeloven (the Opening Hours Act) is the law defines when shops are allowed to stay open. In addition to the above mentioned holidays, the law prohibits most shops from staying open on Constitution Day (5 June), Christmas Eve, New Year's Eve (partially) after 15:00, so shop staff have these days off. Others usually do not work on Christmas Eve and New Year's Eve, though this is not covered by any legislation. 2) Labour Day (1 May) is not mentioned in any legislation, but for people working under a trade union agreement (80% of the work force does that), either Constitution Day or Labour Day (depending on local/industry agreements) is a day off (except for police officers, nurses etc. who also work on weekends).

Would these days be appropriate to include in Yasumi? Which type should they classified as?

[stelgenhof]

Hi @c960657

Thank you very much for your PR and the extensive information. Really appreciate that! As for your question regarding 'other' holidays, in Yasumi you can currently classify days in 5 different ways:

• Official (i.e. public or national holidays)
• Observance (Holidays that are celebrated but are generally a working day)
• Seasonal (Holidays associated to seasonal events e.g. Summer Solstice)
• Bank (Bank holiday)
• Other (any other type of holiday)

This classification covers I think most of the situations however there are always exceptions :). In your case I would classify these days as 'observance'.

Note: The Yasumi classification is merely a category and has no particular logic associated. The classification can be helpful in your project where you may have some business logic related to certain holiday types.

Hopefully that anwwers your question.

Cheers! Sacha

[c960657]

Thanks for clarifying. I'll make a separate PR for adding those days.

[stelgenhof]

@c960657 Sorry for the delay. I thought you were going to make additional changes in this PR. I misread you are going to create additional PR's :) I'll review it once more and merge it ASAP.

[c960657]

I have filed a separate PR for the observed holidays: #104