azuyalabs / yasumi

The easy PHP Library for calculating holidays
https://www.yasumi.dev
Other
1.04k stars 152 forks source link

New translation for Norway’s national day #98

Closed c960657 closed 6 years ago

c960657 commented 6 years ago

I believe the usual name for Norway's national day on 17 May is Grunnlovsdag (National Day) or Grunnlovsdagen (The National Day).

I don't know of any official source to quote, but here are some examples:

Disclaimer: I am not a native Norwegian speaker, but being from Denmark, I can read the other Scandinavian languages. Perhaps a Norwegian can chip in here?

stelgenhof commented 6 years ago

Hi @c960657 !

Thanks for the PR. When I added this provider for Norway I based my information on Wikipedia: https://en.wikipedia.org/wiki/Norwegian_Constitution_Day

Of course it maybe incorrect, however it says "grunnlovsdag" is less frequently used so that's why I initially used the former name. Anyway I am happy to merge your PR if "grunnlovsdag" is the better name :)

Cheers! Sacha

c960657 commented 6 years ago

Hi @stelgenhof,

We better get confirmation from a Norwegian before changing anything :-)

FWIW, the Wikipedia quote was added here and the footnote reference was added here, but the referenced web page no longer mentions the holiday name.

stelgenhof commented 6 years ago

Thanks! If you happen to know somebody from Norway that would be great. Unfortunately I don't :(

stelgenhof commented 6 years ago

@c960657 Can I merge this PR or are you still trying to get someone to confirm the translation? Just wanted to check :)

c960657 commented 6 years ago

No, sorry, don't have a Norwegian at hand :-) I suggest we just keep this issue open and wait for a Norwegian to confirm/reject the proposal, if that is okay with you.

stelgenhof commented 6 years ago

@c960657 No worries! It may take a long time before we can find someone to verify this. I suggest the opposite: merge your request and if in the future somebody disagrees, a fix can be applied.

Personally I prefer issues not to be open long time.

creuzerm commented 6 years ago

We are asking which is more correct Grunnlovsdag vs Grunnlovsdagen ? Correct?

I can email a Norwegian Colleague to get clarification. It's already end of day there, so it may take me a day or two to get back with an answer.

c960657 commented 6 years ago

I think the question should rather be “which is more commonly used in writing in lists of holidays?”, i.e. we are not interested in something formally correct but never used in practice, and not in very informal usage either.

creuzerm commented 6 years ago

I asked a Norwegian and got back the following answer. I think he put it in terms that are useful for this discussion.

It is Grunnlovsdagen when referring to the specific day of May 17th

(Both are correct, but different grammatical forms - and to refer to the specific case you use Grunnlovsdagen not the general case)

c960657 commented 6 years ago

Grunnlovsdagen it is then :-) Thanks!

c960657 commented 6 years ago

Incidentally, Norway's national day is today! 🇳🇴

stelgenhof commented 6 years ago

@c960657 Can you change the target branch of this PR to 'develop' as that is the base branch? At the moment the PR is set for merge to the 'master' branch.

c960657 commented 6 years ago

Done :)