search

b-ivey / css-project

0 stars 0 forks source link

Sarah Braddock #2

Open svbraddock opened 4 years ago

svbraddock commented 4 years ago

https://github.com/svbraddock/CSS-Project

b-ivey commented 4 years ago

Double check your HTML code. It’s not linking to the style.css properly.

Make sure you put your code through a validator.

On Apr 8, 2020, at 9:36 PM, svbraddock notifications@github.com wrote:

https://github.com/svbraddock/CSS-Project https://github.com/svbraddock/CSS-Project — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/b-ivey/css-project/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOIV3PCYYNXCFWG3P7YFHIDRLURDTANCNFSM4MELTQ5Q.

svbraddock commented 4 years ago

Hi Professor Ivey! For some reason when I have my CSS style sheet in a different folder it doesn't link up properly. It should work now, thanks!

b-ivey commented 4 years ago

Ok, it’s a pretty easy fix. You just need to add the folder name first then the name of the stylesheet. It worked for me when I fixed it. But girl! THIS IS FANTASTIC!

I noticed you didn’t try any grids. You also needed to put in a max-width on the page. Both of these items were on the requirement list. Do you want to try to add them?

On Apr 8, 2020, at 9:57 PM, svbraddock notifications@github.com wrote:

Hi Professor Ivey! For some reason when I have my CSS style sheet in a different folder it doesn't link up properly. It should work now, thanks!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/b-ivey/css-project/issues/2#issuecomment-611284507, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOIV3PFKPDMLUPUJDCYSV4LRLUTRPANCNFSM4MELTQ5Q.

svbraddock commented 4 years ago

Just re-did the code with the grid and max-width, and thank you! The examples you posted helped a lot!

b-ivey commented 4 years ago

Oh good! I'm glad the examples are helping.

b-ivey commented 4 years ago

This is such a great site. I wish I had noticed the container width was too much. That should have a max width of 960 pixels.

Great job of going above and beyond what we learned in class. I noticed you had some fancy code in there, so kudos for that.

For your site (assuming you're doing a professional portfolio site), you should bring your text sizes down a bit. They're kinda large.

The footer could be much smaller in height and consider floating all the elements to the right so they line up on one line.

Finally, be sure you organize your directory clearly. All images need to be in an img folder. Your naming conventions on the files should be more traditional. All home pages should be titled index.html. The rest of your pages should have the same name as the nav buttons, which should only contain one word.