search

b-r-u / osmpbf

A Rust library for reading the OpenStreetMap PBF file format (*.osm.pbf).
Apache License 2.0
120 stars 18 forks source link

Simplify RelMemberType #33

Open nyurik opened 2 years ago

nyurik commented 2 years ago

This makes the code a bit more performant by removing the wrapping RelMemberType as a separate enum. No point now with protobuf3 as it gets generated as is.

I had to modify the .proto file to make the casing consistent, but eventually I do hope the protobuf lib itself can do that on the fly.

See also https://github.com/stepancheg/rust-protobuf/issues/639

b-r-u commented 2 years ago

Hey nyurik, sorry for taking so long to respond.

I would refrain from changing the *.proto files in a semantic way for now, as it would make it harder to track the upstream changes. The performance cost seems minimal, but I would welcome the reduced complexity if your issue gets resolved in rust-protobuf.