b0o / surfingkeys-conf

🏄 A SurfingKeys config which adds 180+ key mappings & 50+ search engines
MIT License
395 stars 67 forks source link

Support for extended active window in full page screenshot keybinding. #28

Closed ertwro closed 1 year ago

ertwro commented 4 years ago

Details

When doing a full page screen-capture, either by yG or yS the normal behavior of surfingkeys-conf is to scroll and composite the screenshot. While this works most of the time, it varies depending on the level of zoom, changes one's current position on the page and it can be glitchy based on one's keyboard and mouse input during capture.

[feature request]

While I get the current behavior is much more general and useful in other browsers, Chromium and Firefox expose a feature called extended active window. This feature takes the screenshot in the background making it zoom, input and animation independent. Normally I get access to it in Chrome type browsers by doing: 1) Do inspect in developer tools by pressing CtrlShifti or F12 2) Run command by pressing CtrlShiftP 3) writing >capture full size screenshot

If I knew enough javascript I would do a pullrequest instead of just mentioning a feature to dump work on you but I'm not a programmer. Maybe this is something you find worthy of including if is not too much work and useful. Thanks for you awesome code.

b0o commented 4 years ago

yG and yS are provided by SurfingKeys itself, not this project. This could possibly be implemented here, but do you think this request would fit better on the main SurfingKeys repo?

ertwro commented 4 years ago

I think the current behavior is much more portable and general. While extended active window has been supported in several versions of Chrome and Firefox, at least since versions 35 and 30 respectively to my knowledge, I see how it could break at some point. Making it more suited for personal configuration. I'll ask in the Surfingkeys repo, keep this issue open while I wait for an opinion there. Feel free to close it. I would reopen it later if by any chance they see merit but think it would be more suited for personal configuration. If you don't mind.

Issue 1263 on Surfingkeys