search

b13 / container

A TYPO3 Extension for creating custom nested content elements
GNU General Public License v2.0
168 stars 67 forks source link

Use the same colPos in multiple containers with diffrent name #164

Closed Xippo closed 3 years ago

Xippo commented 3 years ago

Thanks for sharing and maintainig this Extension :)

My Setup: TYPO3 10.4.17 Container: 1.3.0 over Composer.

If I implement two containers that share a colPos (200) and I rename the colPos in the second element, the name from the first element is still used. Im not sure if its a bug or bad practice to use the same colPos for diffrent containers. In Gridelements i could share the colPos and setup different names. I know this is not Gridelements and im fine when its not intended by design to share colPos

achimfritz commented 3 years ago

Hi @Xippo do you use "Fluid based page module" Feature? I think this is already fixed in dev-master with https://github.com/b13/container/pull/143/commits/49e44319be2ed91d5853fc3f3ab9591421870788 (s. also https://github.com/b13/container/issues/142) can you test master-branch?

Xippo commented 3 years ago

Hi @achimfritz , thanks for the quick answer. Sorry I had not seen the #142 before, my bed :(. I will test the master an report. It is a new TYPO3 10 instance and I believe the feature is on by default, therefore I think it is active but I will check it. Does the extension support only the new mode?

Xippo commented 3 years ago

I have tested the dev-master, there it works like a charm. In the system fluid based page module is enabled. Thx for your help.