b3rs3rk / gpustat-unraid

An UnRAID plugin for displaying GPU status
https://forums.unraid.net/topic/89453-plugin-gpu-statistics/?tab=comments#comment-830112
MIT License
50 stars 12 forks source link

changed .plg output from php to bash #15

Closed ich777 closed 3 years ago

b3rs3rk commented 3 years ago

Okay, so two things:

  1. While this particular change does not qualify because the only code change is to the plugin file (and I only make changes to that file in master), make all future code contributions against the dev branch instead of master. If you checkout my dev branch locally before you make the changes and commit them it will automatically try to open the PR against my dev branch next time.
  2. My personal policy is I won't accept binary data in a pull request unless it is a type of media (image data). By you running the package creation script and committing the result, I am bound to not only review the changes you made in my codebase but also to check the contents of the .txz file that was created. @mlapaglia did the same with his previous PR and I had him revert his branch as well.

After reviewing your commits, I only need the first one. Go back into your local branch, and issue:

git reset --hard abc57c31a8f4f219c57479bd8a8b3f7abd6cea23
git push --force

It should auto update this PR to only include your original gpustat.plg changes. From there, I will run the script to author the package.