search

ba-st / Willow-Bootstrap

Integration between Willow & Bootstrap 3/4
MIT License
7 stars 1 forks source link

Bootstrap4 Navigation bar added (adapted from Bootstrap3 Navigation bar) #120

Open sanjayminni opened 3 years ago

sanjayminni commented 3 years ago

Hi I have adapted a Bootstrap4 Navigation Bar from the Bootstrap3 Navigation Bar - you can check if its useful and adopt it into the willow-bootstrap. thanks

fortizpenaloza commented 3 years ago

Hi @sanjayminni , thanks for contributing.

Can you specify what do you mean by "adapted"? Bootstrap 4 describes a navbar here https://getbootstrap.com/docs/4.0/components/navbar/ . Does your solution conforms with it?

Last but not least, could you write some unit tests?

sanjayminni commented 3 years ago

Hi Francisco,

please note I am not a guru or a skilled programmer

by adapted I meant I had taken the willow Bootstrap 3 as base for functionalities and modified it as required native to Bootstrap4

Yes I have tried to match the code to the first example here https://getbootstrap.com/docs/4.0/components/navbar/ as the objective here is the code this class generates with my unit test

I can write a set of unit tests - however what i want to know is - how do you usually get the code fragment to assert the test against - do you take a code generated by a working test and insert it or is there any other way.

with warm regards Sanjay Minni

On Fri, 23 Jul 2021 at 17:09, Francisco Ortiz Peñaloza < @.***> wrote:

Hi @sanjayminni https://github.com/sanjayminni , thanks for contributing.

Can you specify what do you mean by "adapted"? Bootstrap 4 describes a navbar here https://getbootstrap.com/docs/4.0/components/navbar/ . Does your solution conforms with it?

Last but not least, could you write some unit tests?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ba-st/Willow-Bootstrap/pull/120#issuecomment-885579875, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC3ZGLWMB36WMLK4TGHBQV3TZFIGTANCNFSM5AZRUHIA .

mtabacman commented 3 years ago

Hi Sanjay.

You'd need to create a Bootstrap4NavigationBarTest class in the Willow-Bootstrap-4-Tests package, based on the tests included in Bootstrap3NavigationBarTest.

The expected html code would be the one presented in the Bootstrap site for that feature, trying to use as little components as possible, so that we are testing mainly the way the navigator bar is rendered, but keeping it "valid" (that is, no empty bar unless that makes sense in a bootstrap 4 app, etc.).

Lets us know if that answers your question, and many thanks for your participation in the project!

sanjayminni commented 3 years ago

Hi Ignore this PR. I had only made a couple of changes in 1 class but this is showing the whole lot. something wrong in the way I forked / committed etc.

this https://discord.com/channels/223421264751099906/311419918631305218/879654296566784020 and subsequent messages may have something to do with this

anyway will try to redo and submit with test cases. am deleting this clone