Add Content-Length header to responses

baalexander / node-xmlrpc

A pure JavaScript XML-RPC client and server for Node.js.

MIT License

295 stars 150 forks source link

Add Content-Length header to responses #146

Closed jhurliman closed 6 years ago

jhurliman commented 6 years ago

This makes server responses more efficient by disabling chunked transfer encoding, but more importantly the Content-Length header is required for all requests and responses by the XML-RPC spec (see http://xmlrpc.scripting.com/spec.html).

jhurliman commented 6 years ago

This change makes node-xmlrpc compatible with XmlRpc++, the library used by C++ ROS clients (http://wiki.ros.org/xmlrpcpp).

jhurliman commented 6 years ago

Ack, I should have checked the open PRs first. #138 includes this exact change plus a unit test. Closing this PR in favor of the previous one.

Let me know if you need any help reviewing and merging PRs; it looks like this project is not actively maintained but it is still the most popular node.js xmlrpc lib.