Fix MD5 sum calculations of messages.

baalexander / rosnodejs

A ROS client library using node.js

http://baalexander.github.com/rosnodejs/

MIT License

36 stars 8 forks source link

Fix MD5 sum calculations of messages. #24

Closed baalexander closed 12 years ago

baalexander commented 12 years ago

The MD5 sum calculated in messages.js returns incorrect values. For example, std_msgs/String returns 5b89344b4d080ca499c0648063c40738 instead of 992ce8a1687cec8c8bd883ec73ca41d1.

md5 sum test cases should also be added to messages_test.js.

maxired commented 12 years ago

I will have a look about this

baalexander commented 12 years ago

Awesome! ROS's genmsg implementation or roslua's implementation may be useful as a reference.

maxired commented 12 years ago

Does https://github.com/baalexander/rosnodejs/pull/26 fix this ?

baalexander commented 12 years ago

Yep, thanks again. I left a couple questions in the pull request.