search

baarde / cert-manager-webhook-ovh

OVH Webhook for Cert Manager
Apache License 2.0
94 stars 63 forks source link

Add release.Namespace in meta and update api #4

Closed spiarh closed 4 years ago

spiarh commented 4 years ago

This is tested with Kubernetes 1.17.4 and cert-manager 0.14.1.

Adding release.Namespace in meta fixes issues when rendering template with 'helm template --namespace'. Without it, the rendered templates do not have the namespace defined which is problematic when using a gitops approach. This is also a requirement for a tool like Spinnaker.

Use cert-manager.io/v1alpha2 and update deprecated API for Deployment

Signed-off-by: lcavajani lcavajani@suse.com

michaelcoll commented 4 years ago

Would be nice to merge this PR.