Fix instant cast detections

[Zerthox]

This fixes effect collisions with Thousand Needles (e.g. Deadeye Shadow Flare). It also adds a way to check for secondary effects. The new cast detection for Thousand Needles happens ~280ms after the related buff is lost (and the previously used effect happens), right as the first hit occurs.

In the future we might want to detect it by buff loss and filter out buff removes too close to dead events.

[Zerthox]

Also fixed false positives for Judges Intervention, Merciful Intervention, Crisis Zone (maybe?). And made Save Yourselves and You Are All Weaklings and Infiltrator's Signet more robust by intersecting all effects.

[Zerthox]

Crisis Zone might still need more looking into, we discovered one of the effects can happen without the other. Either one effect is reused or the other does not happen every time.

[Zerthox]

The effect is also used delayed after the Mech spawns with Crash Down. I swapped the effects so that the reused effect is a secondary check.

[EliphasNUIT]

This is getting a little bit confusing for me. Could you summarize the status for the following please (latest release combined with what is in this PR)?

• Which instant casts still currently collide with something else?
• Which instant casts still trigger less than expected?
• Which instant casts detection timings are not correct ?

Thanks.

[Zerthox]

This PR fixes collisions for:

1. Thief Thousand Needles false positive triggered by Shadow Flare (effect reuse). Fixed by detecting cast via buff instead and checking for related effects (marked as not accurate due to effect usage).
2. Guardian Merciful Intervention false positive triggered by Judges Intervention (buff reuse). Fixed by checking for related effects like above.
3. Guardian Judges Intervention false positive triggered by Symbol of Blades (effect reuse). Fixed via changing to copy of above but with different effect to distinguish.
4. Mechanist Crisis Zone false positive triggered by Crash Down (effect reuse). Fixed by checking secondary effect.
5. Mesmer Blink false positive & negative. Simply a typo in the code.

As of now I am not aware of any other known false positives or false negatives. So no known collisions and no known casts triggering less than expected. The timings should be correct now with the Buff + Effect hybrid detections.

[EliphasNUIT]

Thanks.

Is everything ready in the PR or do you have more work to do?

[Zerthox]

Everything ready.

[EliphasNUIT]

Thanks!