Portal decorations in combat replay

[Zerthox]

Portal decorations for:

• Mesmer Portal (inactive & active)
• Thief Shadow Portal
• Scourge Sand Swell
• White Mantle/Watchwork Portal

[Zerthox]

Should the GetEffectsForPlayer and GetGroupedEffectsForPlayer helpers be moved somewhere else? Currently they are in ProfHelper.

[EliphasNUIT]

They can be moved to CombatData as a Public API and remove "Player" notion from it to work directly with an AgentItem like other GetXXXEvents.

[EliphasNUIT]

Like GetEffectEventsBySrcWithGUID or something

[EliphasNUIT]

Looks great! You think you could complete all the portals by adding properly sized and colored circle decorations (with UsingSkillMode) at the same position as the icon decorations?

[Zerthox]

So two separate decorations? If it's about getting an idea of how large the portals actually are, maybe the icon could resize when the "use hitbox size" option is enabled?

[EliphasNUIT]

Yeah, I was thinking as a separate decoration. The icon resize is not without interest but I would say that it is an orthogonal evolution to adding circles to represent portals.

[Zerthox]

Should portals always render or only on player select? I was thinking the active ones probably should be always displayed since they affect all players. Not sure about inactive portals.

[EliphasNUIT]

Active portals should be always active yes, the inactive ones should be on select only.

[EliphasNUIT]

Looks great! Thanks.

[Zerthox]

Some closing notes for future reference: Right now active portals are always displayed whereas inactive ones are only displayed on player select. Portal decoration radius is currently 90 units, roughly matching the ingame visual effect size. Actual functional interact size seems to be ~100 units.