search

baaron4 / GW2-Elite-Insights-Parser

Binary parser for the .evtc files that arcdps generates after a boss encounter. This will generate a .html file where the results can be easily reviewed.
MIT License
136 stars 48 forks source link

Fix thief venom stacks capacity #913

Closed Linkaaaaa closed 4 months ago

Linkaaaaa commented 4 months ago

They got increased in the 25/06 patch https://wiki.guildwars2.com/wiki/Game_updates/2024-06-25#Thief venoms.zip

EliphasNUIT commented 4 months ago

If there is something wrong with BuffInfoEvent.MaxStack it is better to report it to ArcDPS than try to do a by-pass.

Linkaaaaa commented 4 months ago

There's nothing wrong, the new buff capacity is logged correctly

EliphasNUIT commented 4 months ago

Then everything is working as expected no?

Linkaaaaa commented 4 months ago

Yes they work but do we want to keep the incorrect number there instead of splitting it with a game build?

EliphasNUIT commented 4 months ago

That is what we have been doing since the introduction of BuffInfoEvent half a decade ago, the burden of maintenance of capacity was shifted to it.

Linkaaaaa commented 4 months ago

Well nevermind then