baaron4 / GW2-Elite-Insights-Parser

Binary parser for the .evtc files that arcdps generates after a boss encounter. This will generate a .html file where the results can be easily reviewed.
MIT License
136 stars 48 forks source link

Split the executalbe into two projects, `Parser` (windowed, name unchanged) and `ParserCLI`. #930

Closed SaculRennorb closed 1 month ago

SaculRennorb commented 1 month ago

Split the executalbe into two projects, windowed (old) and cli. Moved Settings into ParserCommon to share it between cli and windowed. Changed the test dependencies to ParserCommon which allows the tests to also target non windows frameworks.

Updated the language version of subprojects to 10 for upcoming changes. Had to change the .editorconfig, because a var declaraion was in violation of an error rule. Probably a change in what is considered for the specific rule between versions. Moved the HighDPI setting form the manifest into the project file. Some of the properties in the windowed project file also got shuffled around, i tried to group them in regards of platform features should we ever want to try and give the unified version another shot.

I really tried to make this work as one codebase, but VS really doesn't want you to build two different executables form the same codebase. I again almost got it working, but in the end the Forms designer wouldnt load. If you ever want to attempt the unification you need to

I did some preliminarily testing and everything seems to work just as before, except you need a new version of the runtime ofcourse. I also don't know your release (pipeline) and you might need to adjust some attributes in the CLI project regarding updating etc.

EliphasNUIT commented 1 month ago

Thanks!