search

babarot / enhancd

:rocket: A next-generation cd command with your interactive filter
2.58k stars 109 forks source link

Going to existing directory is still showing the filter #207

Open augustocdias opened 1 year ago

augustocdias commented 1 year ago

When I cd to an exact match within the CWD it is still showing the filter to select an option.

This is happening in fish on mac os arm.

babarot commented 1 year ago

More detail please

Nightlord851108 commented 1 year ago

I am in the same issue, too. In arm, when you are cd in to an exist directory, it should be auto completed with tab. For example: cd ~/Down and tap tab, and it will auto completed as cd ~/Download. But it did not.

ibeex commented 1 year ago

same here Fish

(exists in cwd) should Go to dir without the filter command (same as builtin cd). But it shows **filter**
augustocdias commented 1 year ago

So this gif shows what happens. When I cd into openmls it is the only one match and it still shows the filter

tty

svengreb commented 1 year ago

I guess this is a duplicate of #206.

boyanxu commented 1 year ago

Same issue. fish, arch_linux, x86_64

Darkclainer commented 1 year ago

Having same issue on master branch.

In my case the reason was that function _enhancd_filter_interactive received two entries from stdin, one of them was specified directory and the other some empty string (probably with whitespaces). I don't understand awk code, so my workaround was to change the function on line 32 from:

    switch "$count"
        case '1'

to

    switch "$count"
        case '2'

This should be fine, because it looks like this function will receive one empty entry in any case.

augustocdias commented 1 year ago

@b4b4r07 is the solution from @Darkclainer the correct approach? I can open a PR if so.

cyrusn commented 1 year ago

I encounter the same issue too. even cd ~/Desktop/ still shows the filter.

Walheimat commented 1 year ago

I have the same issue, clean install of Ubuntu 23.10, using fish shell. Will use hack @Darkclainer suggested for now.

Darkclainer commented 1 year ago

@augustocdias, I saw you made a more correct (in my opinion) fix: https://github.com/augustocdias/enhancd/commit/a6b9835d3a1e40d5dfd98c90aa2818eea56f03e2. Could you please create PR, so the maintainer, at least will identify the problem more clearly or hopefully will merge fix?