search

babashka / neil

A CLI to add common aliases and features to deps.edn-based projects
MIT License
360 stars 26 forks source link

`neil dep add` exits with code 0 on both failure and success #185

Closed joakimen closed 4 months ago

joakimen commented 1 year ago

When neil dep add fails to add a dependency, it still exits with code 0.

# bash

$ cat deps.edn
{}

$ neil dep add "com.cognitect.aws/s3"; echo $?
0

$ cat deps.edn
{:deps {com.cognitect.aws/s3 {:mvn/version "848.2.1400.0"}}}

$ neil dep add "some-fake-dep"; echo $?
0

$ cat deps.edn
{:deps {com.cognitect.aws/s3 {:mvn/version "848.2.1400.0"}}}

Discussion: https://clojurians.slack.com/archives/C03KCV7TM6F/p1688836219372089

borkdude commented 1 year ago

ok, I think printing a warning and then exiting with 1 would be ok