babylonchain / babylon-finality-gadget

2 stars 2 forks source link

feat: add cw stub contract for the DA (for easy testing) #20

Closed bap2pecs closed 2 months ago

bap2pecs commented 2 months ago

Summary

we have been using this for testing e2e tests and it has been working quite well. so uploading it here

Test Plan

make build

see the contract I deployed here: https://www.seiscan.app/atlantic-2/query?contract=sei16ckfmlym6wv5hwptuzpeumen028cu065a77ypj4dp7k56fsmj9hqx6t4gy

image

SebastianElvis commented 2 months ago

If using a stub contract on a public blockchain, the e2e test status will depend on some external services, which is not ideal. How about in the e2e test we spin up a local babylon/wasmd node for hosting the smart contract? Finality provider is following this approach, e.g., see here

bap2pecs commented 2 months ago

@SebastianElvis for sure we are worknig on e2e test, but this still makes it easier for us to test stuff. so I am just gonna mege it to save time on rebasing

lmk if you have any q

SebastianElvis commented 2 months ago

Sure maybe we can keey this stub contract to unblock some tasks for now. But I anticipate it will be removed at some point and instead we test things e2e against the DA contract wasm binary