Closed teddychao closed 8 months ago
Hi @teddychao. I made some changes, please check the diff for my recent commit.
return
). Please merge if you are happy. Please also update the documentation.
fixed some error display bugs, previously it was not displayed properly
fixed a strange expression error, not sure about why.
fixed the invalid \
at the end of line
@teddychao thanks for reviewing. Please update GUI & documentation as well.
Hi @dominikbach I have completed these features. However, I have a question. Currently chan_valid_cutoff
(originally nan_cutoff
) is used when data combination operation is used. I am not sure if this value should be used if data combination behaviour is not used by users? For instance, users want to just do preprocessing for a channel they focus on, should chan_valid_cutoff
be used at all? I have this question because data combination checking currently allows a situation that only the primary data channel is processed and used as the output when the data to combine channel is invalid.
@teddychao Thanks, I have added a warning and slightly re-worded GUI and Manual text.
Summary
Add
pupil_pp
's missing value filtering. This pull request added aNaN
checking step inpupil_pp
. The cut off value is set to be 10% (0.1) inpspm_options
. If the missing values are more than the cut-off value of the full data, thenpupil_pp
will stop and report the error message saying "... has more than .... % missing values."