Enable denoising for all continuous marker channels

bachlab / PsPM

A matlab suite for Psycho-Physiological Modelling

GNU General Public License v3.0

43 stars 11 forks source link

Enable denoising for all continuous marker channels #636

Closed dominikbach closed 9 months ago

dominikbach commented 9 months ago

Fixes #634.

Changes proposed in this pull request:

enable denosing of event channels other than smr format
change format of argument denoise to specification in seconds, rather than milliseconds, as we want to use SI units wherever possible
adapt tests

teddychao commented 9 months ago

Sorry I spent a few minutes to understand what was going on there... The basic logic is to use lo2hi and hi2lo to identify pulses, and then use .denoise to validate those pulses. If .denoise is specified, only the lo2hi and hi2lo that allow longer duration (than .denoise) can be accepted for following processing. Hope my understanding is correct.

I only added minor adjustments for the help text in pspm_get_events for recording this update.