Fix `pspm_extract_segments`

bachlab / PsPM

A matlab suite for Psycho-Physiological Modelling

GNU General Public License v3.0

43 stars 11 forks source link

Fix `pspm_extract_segments` #771

Closed dominikbach closed 2 months ago

dominikbach commented 2 months ago

Fixes a bug detected in beta testing.

Changes proposed in this pull request:

save events in pspm_glm
correct computation of events in case of edge cases in pspm_glm
add time stamp to the glm struct for troubleshooting
correct pspm_extract_segments when time units are markers and input is a GLM

teddychao commented 2 months ago

In pspm_extract_segments_test, at line 208, pspm_extract_segments expects that glm has the field glm.input.events, as this is used by line 158 in pspm_extract_segments. In the current version of pspm_extract_segments_test, there is no glm.input.events. I do not know if the test data shall be updated?

This has been resolved after updating dataset. Thank you.