search

backdrop-contrib / css_injector

Allows administrators to inject CSS into the page output based on configurable rules
GNU General Public License v2.0
0 stars 1 forks source link

Linked CDN version of ACE is extremely outdated #11

Closed indigoxela closed 3 months ago

indigoxela commented 4 months ago

Oops, that's 1.2.4? How old is that? (Edit: it's 8 years old.)

https://github.com/backdrop-contrib/css_injector/blob/1.x-1.x/css_injector.admin.inc#L136

Most recent version is 1.34.1, and it seems to play just nicely with this module.

https://cdnjs.com/libraries/ace

indigoxela commented 4 months ago

Here's a pull request, that updates the links - for your kind review @vstemen

https://github.com/backdrop-contrib/css_injector/pull/12

olafgrabienski commented 4 months ago

Tested the PR on a local site (combined with PR for #13). If I don't miss anything, with the new library version everything continues to work as expected.

klonos commented 3 months ago

Thank you @indigoxela and @yorkshire-pudding 🙏🏼 ...eventually, I'd like to provide a setting somewhere in the UI so that people can update the links to the CDN w/o having to wait for a new release of the module. But that's good enough for now.

yorkshire-pudding commented 3 months ago

@klonos - Did you mean @olafgrabienski ?

klonos commented 3 months ago

Yes. I meant @olafgrabienski indeed 🙂