search

backdrop-contrib / css_injector

Allows administrators to inject CSS into the page output based on configurable rules
GNU General Public License v2.0
0 stars 1 forks source link

Doesn't work since core V1.16.0 #4

Closed metatop closed 4 years ago

metatop commented 4 years ago

Doesn't work since core V1.16.0

To make it work you have to disable: Aggregate and compress CSS files in Performances

css-compress

vstemen commented 4 years ago

That's a Backdrop setting in core under Configuration -> Development. I wonder if this should be reported as an issue for core (since css_injector has been working all this time until now and has not been changed). I don't know if there is anything in css_injector that can be changed to affect it. Unless there is some API compatibility change to backdrop that requires updates to modules such as css_injector.

indigoxela commented 4 years ago

I wonder if this should be reported as an issue for core (since css_injector has been working all this time until now and has not been changed)

@vstemen it has been reported in core Issue queue: https://github.com/backdrop/backdrop-issues/issues/4414

indigoxela commented 4 years ago

@metatop "Doesn't work" is a sparse description. :wink:

You could make life easier for module/core maintainers, if you describe a bit more in detail, what is currently broken.

Is it the inserting/editing of css code? Or is the css code not added to pages? What are the steps to reproduce?

metatop commented 4 years ago

@metatop "Doesn't work" is a sparse description. 😉

You could make life easier for module/core maintainers, if you describe a bit more in detail, what is currently broken.

Is it the inserting/editing of css code? Or is the css code not added to pages? What are the steps to reproduce?

Sorry, my English is horrible and I tend to summarize too much.

The css code not added to pages when "aggregate and compress CSS files" is active.

metatop commented 4 years ago

That's a Backdrop setting in core under Configuration -> Development. I wonder if this should be reported as an issue for core (since css_injector has been working all this time until now and has not been changed). I don't know if there is anything in css_injector that can be changed to affect it. Unless there is some API compatibility change to backdrop that requires updates to modules such as css_injector.

I think the same

indigoxela commented 4 years ago

I tried to reproduce it, but couldn't.

My steps:

indigoxela commented 4 years ago

@metatop maybe it's related to settings?

Here's a screenshot of mine, can you make sure "Preprocess CSS" is turned on in your install? screenshot-css-injector

metatop commented 4 years ago

Preprocess CSS is active.

I've tried a new site and the bug doesn't reproduce, I don't know where the bug may be, the only thing I know is that it stopped working when I installed version 1.16 in producction site.

Keep investigating...

jenlampton commented 4 years ago

@metatop did you run the update script update.php after the update to 1.16? A cache clear was needed with that update, and wihtout it a site could experience the problems you are describing here.

I'm going to mark the core issue as "cannot reproduce" until we can have someone else confirm the bug.

metatop commented 4 years ago

@metatop did you run the update script update.php after the update to 1.16? A cache clear was needed with that update, and wihtout it a site could experience the problems you are describing here.

I'm going to mark the core issue as "cannot reproduce" until we can have someone else confirm the bug. I run update.php and also clear cache

metatop commented 4 years ago

I've finally made it work by erasing all the rules I had and creating them again. Sorry for the inconvenience.

indigoxela commented 4 years ago

I've finally made it work

@metatop glad you sorted things out.