search

backdrop-contrib / css_injector

Allows administrators to inject CSS into the page output based on configurable rules
GNU General Public License v2.0
0 stars 1 forks source link

Move configuration from database to config file #6

Open AlexHoebart-ICPDR opened 2 years ago

AlexHoebart-ICPDR commented 2 years ago

Hello, while using Backdrop's configuration manager to synchronise my dev to test site, I noticed that it fails for css_injector. Although, there is a config file css_injector.settings.json, most configuration is still saved into a database table called css_injector_rule. Without that, the css files in files/css_injector are not used. Shouldn't these rule definitions also be in the configuration file?

klonos commented 2 years ago

Hello @AlexHoebart-ICPDR 👋🏼

I had applied to become a co-maintainer of this project a long time ago (see #5), but the initial maintainer took some time to reply, and then it also took me till now to notice (sorry, real life obligations). Well, I am now a co-maintainer of this project, and plan to start looking into reported issues as soon as possible.

I'll reply here soon as I had a chance to review the code of the module, but it seems from what you are reporting that the porting of the module is incomplete, or there is things that we've missed during the initial porting. Please bear with us.

vstemen commented 2 years ago

Hello @AlexHoebart-ICPDR and @klonos.

I began reviewing the code but, @klonos, if you are more more familiar with Backcdrop code, you will probably be quicker at getting the rest of the settings moved over to backdrop config. css_injector was my first port from Drupal and that was a few years ago, so I am still pretty green at it. I will try to make some time to continue looking over the code but if you are able to do it before I can get to it that would be great!