search

backdrop-contrib / css_injector

Allows administrators to inject CSS into the page output based on configurable rules
GNU General Public License v2.0
0 stars 1 forks source link

Uncaught ReferenceError: Drupal is not defined #9

Closed indigoxela closed 3 months ago

indigoxela commented 4 months ago

That's a JS error thrown, if the Drupal compatibility layer is off.

$settings['backdrop_drupal_compatibility'] = FALSE;

Without that compat setting, syntax_highlighter.js completely breaks.

Simple solution:

  Backdrop.behaviors.slideUpDown = {
indigoxela commented 4 months ago

A pull request is available: https://github.com/backdrop-contrib/css_injector/pull/10

@vstemen not sure, if you're still around, but if you are - please review. :smiley:

olafgrabienski commented 4 months ago

Confirmed the issue, and the PR fixes it for me (after clearing the CSS and JS cache).

argiepiano commented 4 months ago

This is good to go. I thought the @backdrop-contrib/bug-squad needed to act, but I see that @klonos is a maintainer, so I'll let him do the merging.

indigoxela commented 3 months ago

@klonos it's been a while now, this PR has been available for maintainer review, but you didn't find the time to chime in, yet. Any chance, this might happen soon-ish?

klonos commented 3 months ago

Apologies folks. Real life, work, as well as other threads in the core queue distracted me. I'm having a look now.