search

backdrop-contrib / honeypot

Backdrop port of Drupal module. Uses both the honeypot and timestamp methods of deterring spam bots from completing forms on your site.
GNU General Public License v2.0
3 stars 1 forks source link

Issue #9 Fixes compulsory 6 second delay on login. #10

Closed Graham-72 closed 8 years ago

Graham-72 commented 8 years ago

Extra parentheses needed in if statement.

herbdool commented 8 years ago

I'm not sure if this is the fix. You can see in Drupal 7 that the parantheses are the same: http://cgit.drupalcode.org/honeypot/tree/honeypot.module?h=7.x-1.x (line 283). The logic is that it first checks if $honeypot_time exists and if it does then it checks which value is greater. I'm not sure if your change would ever catch any errors.

The one change I do see on the Drupal 7 version is that they're using REQUEST_TIME so perhaps there are some commits that can be applied and maybe one of them could fix an issue you're seeing.

Graham-72 commented 8 years ago

@herbdool thanks, understood. I was too hasty with this PR. I will look more carefully at what is happening.