search

backdrop-contrib / icon_browser

An interface to browse the fonts that are available on a Backdrop site.
GNU General Public License v2.0
2 stars 3 forks source link

Reset selected icon #8

Closed stpaultim closed 6 months ago

stpaultim commented 6 months ago

This seems a little weird to me and could be made a little better.

Steps to reproduce:

1) Install Icon Browser module and On the Web 2) Filter for icons provided by modules 3) Select "Delicious" icon 4) Change filter to show all icons

Note "Delicious" icon is still highlighted at top.

5) Click "Reset"

Note "Delicious" icon is still highlighted at top

image

I think maybe the selected icon should be reset to NONE at step 4. If not at step 4, then certainly at step 5 when one selects "Reset".

laryn commented 6 months ago

I also noticed that saving defaults also saves the keyword, which is probably not commonly expected.

laryn commented 6 months ago

This should be fixed in https://github.com/backdrop-contrib/icon_browser/commit/6b7b64bc9fd5f6f799fa176849541937b5cc98ed

stpaultim commented 6 months ago

@laryn Confirmed. Thank you!