search

backdrop-contrib / print

Generate printer-friendly, PDF, EPub, and/or email versions of site content.
GNU General Public License v2.0
1 stars 4 forks source link

Remove Remove the use of jQuery load() method to handle load events #31

Closed argiepiano closed 2 months ago

argiepiano commented 3 months ago

This module uses the jquery method load() to handle the load event in print.pages.inc. This method was deprecated, and causes Javascript to crash when used with jQuery 3, which is now the default for Backdrop.

The use of the event handler load(function(){}) should be converted to on('load', function(){})

laryn commented 2 months ago

@argiepiano This module is still messy in a lot of places, but I don't think I'm using it anywhere and don't have free time to do more than just patch this immediate issue -- care to test the PR and see if it fixes the problem on your end?

argiepiano commented 2 months ago

@laryn I've tested and the PR does fix the problem. Thanks!

laryn commented 2 months ago

Thanks!